Skip to content

♻️E2E: Fix DEBUG logging not outputing to the logs #8523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2025
Merged

♻️E2E: Fix DEBUG logging not outputing to the logs #8523

merged 2 commits into from
Oct 16, 2025
+136 −144

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Oct 16, 2025 •
edited
Loading

What do these changes do?

With the goal of fixing the "videostreaming does not work" assumption, this PR fixes the logging level being hard-coded to INFO.

The idea here is to permit DEBUG logging to see what are the messages coming into the websocket when running on CI machines. Locally I was unable to reproduce that problem out of >20 times.

This will be very verbose, but that might at least give a hint
image

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Imparable milestone Oct 16, 2025
@sanderegg sanderegg self-assigned this Oct 16, 2025
@sanderegg sanderegg added t:maintenance Some planned maintenance work e2e Bugs found by or related to the end-2-end testing 🤖-automerge marks PR as ready to be merged for Mergify labels Oct 16, 2025
@sanderegg sanderegg force-pushed the e2e/fix-debug-logging branch from f033bf2 to d59d96f Compare October 16, 2025 08:55
@codecov
Copy link

codecov bot commented Oct 16, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.55%. Comparing base (0231c39) to head (ee086aa).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8523      +/-   ##
==========================================
+ Coverage   87.01%   87.55%   +0.53%     
==========================================
  Files        2007     2007              
  Lines       78402    78402              
  Branches     1343     1343              
==========================================
+ Hits        68222    68641     +419     
+ Misses       9778     9359     -419     
  Partials      402      402
Flag Coverage Δ
integrationtests 63.99% <ø> (+3.55%) ⬆️
unittests 86.26% <ø> (+<0.01%) ⬆️
Components Coverage Δ
pkg_aws_library 93.61% <ø> (ø)
pkg_celery_library 85.83% <ø> (ø)
pkg_dask_task_models_library 79.33% <ø> (ø)
pkg_models_library 92.90% <ø> (ø)
pkg_notifications_library 85.20% <ø> (ø)
pkg_postgres_database 87.95% <ø> (ø)
pkg_service_integration 70.17% <ø> (ø)
pkg_service_library 70.96% <ø> (ø)
pkg_settings_library 90.20% <ø> (ø)
pkg_simcore_sdk 84.95% <ø> (ø)
agent 93.10% <ø> (ø)
api_server 91.76% <ø> (ø)
autoscaling 95.00% <ø> (ø)
catalog 92.06% <ø> (ø)
clusters_keeper 99.14% <ø> (ø)
dask_sidecar 92.38% <ø> (+0.22%) ⬆️
datcore_adapter 97.95% <ø> (ø)
director 75.72% <ø> (-0.09%) ⬇️
director_v2 90.93% <ø> (+5.63%) ⬆️
dynamic_scheduler 96.82% <ø> (ø)
dynamic_sidecar 90.44% <ø> (ø)
efs_guardian 89.83% <ø> (ø)
invitations 90.90% <ø> (ø)
payments 92.80% <ø> (ø)
resource_usage_tracker 92.11% <ø> (-0.06%) ⬇️
storage 86.79% <ø> (+0.28%) ⬆️
webclient ∅ <ø> (∅)
webserver 87.08% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0231c39...ee086aa. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Oct 16, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for ee086aa.

🟢 All jobs passed!

But CI Insights is watching 👀

@sanderegg sanderegg force-pushed the e2e/fix-debug-logging branch from d59d96f to ee086aa Compare October 16, 2025 09:56
@sanderegg
Copy link
Member Author

sanderegg commented Oct 16, 2025

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Oct 16, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
      • any of: [🛡 GitHub branch protection]
        • check-success = SonarCloud Code Analysis
        • check-neutral = SonarCloud Code Analysis
        • check-skipped = SonarCloud Code Analysis
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 16, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

GitHK
GitHK approved these changes Oct 16, 2025
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sanderegg sanderegg merged commit c9da77d into ITISFoundation:master Oct 16, 2025
95 checks passed
@sanderegg sanderegg deleted the e2e/fix-debug-logging branch October 16, 2025 10:32
This was referenced Oct 28, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66 matusdrobuliak66 is a code owner

@odeimaiz odeimaiz Awaiting requested review from odeimaiz

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@sanderegg sanderegg

Labels

🤖-automerge marks PR as ready to be merged for Mergify e2e Bugs found by or related to the end-2-end testing t:maintenance Some planned maintenance work

Projects

None yet

Milestone

Imparable

Development

Successfully merging this pull request may close these issues.

4 participants

@sanderegg @giancarloromeo @GitHK @pcrespov